[pooma-dev] Re: [PATCH] Speed up guard update.

[Jeffrey D. Oldham]

Richard Guenther wrote:
> On Thu, 15 Jan 2004, Jeffrey D. Oldham wrote:
> 
> 
>>Richard Guenther wrote:
>>
>>>Hi!
>>>
>>>This is a refined (aka shorter) patch which unifies the tracking of
>>>up-to-date faces and the special optimized copy for MPI.
>>>
>>>Tested on serial ia32 linux with gcc3.4 with no regression.
>>>
>>>Ok?
>>
>>Yes, assuming the user interface did not change.  It looks like
>>GCFillInfo's interface changed but existing code will still run because
>>a parameter with a default argument was added.
> 
> 
> It depends on where you draw the line between "user" interface and
> internal interface.  I'd consider GCFillInfo's internal interface, only
> the fillGuards(), setDirty(), etc. methods from the MultiPatchEngine I'd
> consider "user" interface - and these ones will still work with old code.
> I also changed the various intersectors to take an additional parameter - old code will
> break if it used this interface (but I consider this not user interface
> either).

Great!  I interpret this a "no change to the user interface".  Would you 
please commit the patch?

-- 
Jeffrey D. Oldham
oldham at codesourcery.com