[pooma-dev] [PATCH] Fix ExpressionTest
Jeffrey D. Oldham
oldham at codesourcery.com
Wed Aug 25 01:50:27 UTC 2004
Richard Guenther wrote:
> Richard Guenther wrote:
>
>> 2004Aug24 Richard Guenther <richard.guenther at uni-tuebingen.de>
>>
>> * src/Engine/Stencil.h: do bounds check only with
>> POOMA_BOUNDS_CHECK.
>> src/Field/DiffOps/FieldStencil.h: rewrite make(stencil,
>> expr), add make(stencil, expr, domain), kill similar
>> broken Accumulate stuff, update documentation.
>
> ^^^^^^^^^^^^^^^^^^^^^^
>
> actually that part is broken. Leaving it in avoids breaking
> OffsetReduction test.
>
> Ok with that part retained? With this and the last patch MPI is also
> regression-free (without looking at particle tests).
>
> Richard.
I guess it's OK to commit. I tried to follow the logic, but you
understand this much more than I. Tomorrow morning, we'll see if the
regression disappears.
>
>> src/Field/tests/ExpressionTest.cpp: use FieldStencilSimple::make
>> with domain argument, don't take view ourselves.
>
>
--
Jeffrey D. Oldham
oldham at codesourcery.com
More information about the pooma-dev
mailing list