[PATCH] kill POOMA_REORDER_ITERATES

Jeffrey D. Oldham oldham at codesourcery.com
Mon Aug 16 23:00:11 UTC 2004


Richard Guenther wrote:

>This patch kills POOMA_REORDER_ITERATES, i.e. assumes it is always set.
>It was used inconsistently before anyways and the stub scheduler doesn't
>reorder iterates anyway and the SerialAsync does so anyway.  So this
>reduces source code complexity.
>
>Not tested, but looks obvious.  Ok?
>
>Richard.
>
>
>2004Aug16  Richard Guenther <richard.guenther at uni-tuebingen.de>
>
>	* configure: remove traces of POOMA_REORDER_ITERATES.
>	src/Evaluator/Evaluator.h: likewise.
>	src/Evaluator/MultiArgEvaluator.h: likewise.
>	src/Evaluator/Reduction.h: likewise.
>	src/Pooma/Pooma.cmpl.cpp: likewise.
>	src/Tulip/SendReceive.h: likewise.
>  
>
>------------------------------------------------------------------------
>
>===== r2/src/Pooma/Pooma.cmpl.cpp 1.3 vs edited =====
>--- 1.3/r2/src/Pooma/Pooma.cmpl.cpp	2004-01-17 16:20:23 +01:00
>+++ edited/r2/src/Pooma/Pooma.cmpl.cpp	2004-08-16 16:47:24 +02:00
>@@ -803,10 +803,6 @@
>     SystemContext_t::runSomething();
>   }
> 
>-# elif POOMA_REORDER_ITERATES
>-
>-  CTAssert(NO_SUPPORT_FOR_THREADS_WITH_MESSAGING);
>-
> # else // we're using the serial scheduler, so we only need to get messages
> 
>   while (Pooma::incomingMessages())
>  
>
This change worries me.  Doesn't this change the code's meaning?

-- 
Jeffrey D. Oldham
oldham at codesourcery.com




More information about the pooma-dev mailing list