[PATCH] Fix dynamic_array_badcreate test
Richard Guenther
rguenth at tat.physik.uni-tuebingen.de
Thu Jan 30 11:20:38 UTC 2003
Hi!
The following patch disables part of the dynamic_array_badcreate test
which seems to be bogous according to comments in the instrumented code.
Ok?
Richard.
diff -Nru a/r2/src/DynamicArray/tests/dynamic_array_badcreate.cpp b/r2/src/DynamicArray/tests/dynamic_array_badcreate.cpp
--- a/r2/src/DynamicArray/tests/dynamic_array_badcreate.cpp Thu Jan 30 12:19:23 2003
+++ b/r2/src/DynamicArray/tests/dynamic_array_badcreate.cpp Thu Jan 30 12:19:23 2003
@@ -109,6 +109,14 @@
tester.out() << "a = " << a << std::endl;
tester.check(a.domain().size() == (D1.size() + 2));
+#if 0
+ // This test is bogous, as the comment in Engine/DynamicEngine.cpp::create()
+ // tells (the check for shared data is commented out):
+ // "It would be nice to assert that no-one else is looking at the engine
+ // when we perform dynamic operations, but all the particle swap operations
+ // take place inside iterates which means the engine is a copy of another
+ // engine, so the data is shared."
+
// Call a function which takes a view and the original DynamicArray
std::cout << "The program should abort in the next operation when it\n";
@@ -116,6 +124,7 @@
std::cout << std::endl;
tester.out() << "Calling testview with a and a(1,3) ..." << std::endl;
tester.check(testview(tester, a, a(Interval<1>(1,3))));
+#endif
// Return resulting error code and exit; Tester will shut down POOMA.
More information about the pooma-dev
mailing list