[PATCH] prevent make from going crazy without SUITE

Jeffrey Oldham oldham at codesourcery.com
Wed Jan 8 22:42:43 UTC 2003


Richard Guenther wrote:
> On Wed, 8 Jan 2003, Jeffrey Oldham wrote:
> 
> 
>>Richard Guenther wrote:
>>
>>>Hi!
>>>
>>>The following patch prevents make from going crazy without a
>>>configured tree (i.e. no SUITE) (remember: exit 1 doesnt do
>>>anything good in $(shell ...) invocations...)
>>
>>I believe the original echo message provides more intuitive information
>>to the user.  Can we use it with your change to 'exit'?
> 
> 
> Well :) The message isnt going to the user, but is used as value for SUITE
> in the makefile - remember, a makefile $(shell cmd) cmd does not care
> about exit values of the command, but just evaluates to the cmds output.
> 
> So at the moment SUITE becomes 'no such file config/*.suite.mk' or the
> like, with my changes it becomes '#NoSuiteFile' and this value causes the
> makefile to abort later rather than going completely crazy and creating
> random directories and files around the curren directory.
> 
> Now ok without changes?
> 
> Richard.

Yes.

Thanks,
Jeffrey D. Oldham
oldham at codesourcery.com




More information about the pooma-dev mailing list