[PATCH] prevent make from going crazy without SUITE
Jeffrey Oldham
oldham at codesourcery.com
Wed Jan 8 16:14:14 UTC 2003
Richard Guenther wrote:
> Hi!
>
> The following patch prevents make from going crazy without a
> configured tree (i.e. no SUITE) (remember: exit 1 doesnt do
> anything good in $(shell ...) invocations...)
>
> Ok?
>
> Richard.
>
> diff -Nru a/r2/config/Shared/findsuite.sh b/r2/config/Shared/findsuite.sh
> --- a/r2/config/Shared/findsuite.sh Wed Jan 8 17:09:35 2003
> +++ b/r2/config/Shared/findsuite.sh Wed Jan 8 17:09:35 2003
> @@ -28,11 +28,12 @@
>
>
> cd $1
> -flist=`ls -1 config/*.suite.mk`
> +flist=`ls 2>/dev/null -1 config/*.suite.mk`
>
> -if [ "$flist" = "" ]; then
> - echo "Cannot find SUITE file. SUITE not set."
> - exit 1
> +if test -z "$flist"; then
> +# return some weird suite to let make fail
> + echo "#NoSuiteFound"
> + exit
> fi
>
> for f in $flist; do
I believe the original echo message provides more intuitive information
to the user. Can we use it with your change to 'exit'?
Thanks,
Jeffrey D. Oldham
oldham at codesourcery.com
More information about the pooma-dev
mailing list