[PATCH] Fix ReduceOverContexts

Jeffrey D. Oldham oldham at codesourcery.com
Tue Dec 2 17:49:37 UTC 2003


Richard Guenther wrote:
> Hi!
> 
> The following patch fixes ReduceOverContext wrt "invalid" participants of
> the reduction (I dont think I ever came along these, though...).
> 
> Seems obviously correct, but it isnt used extensively (only user of the
> validity argument seems to be Reduction<RemoteMultiPatchEvaluatorTag> and
> the case of invalidity is not covered in the testsuite).
> 
> The problem is that if the owning context has an invalid value, we're
> calling the reduction operator on an uninitialized value. Ugh.
> 
> Ok?

Yes.  Please correct the spelling noted below.

> @@ -280,9 +279,13 @@
>      me->toReceive_m--;
>    }
> 
> - // The actual value we're reducing.
> +  // The actual value we're reducing.
> 
>    T value_m;
> +
> +  // If its valid.

Will you please change the spelling to:

If it's valid.

-- 
Jeffrey D. Oldham
oldham at codesourcery.com




More information about the pooma-dev mailing list