On Fri, May 04, 2001 at 11:54:04AM -0600, Scott Haney wrote:
> On Friday, May 4, 2001, at 10:05 AM, Jeffrey Oldham wrote:
>
> > Do you agree this is a problem? Is the attached patch acceptable? (I
> > am experiencing compilation problems so I have not tested the patch.)
>
> Hi Jeffrey,
>
> Yes, I now see this. However, the patch is not correct. The right thing
> is to call shrinkRight (in Domain/Shrink.h) with "1". We only want to
> remove one value in each direction.
Is the attached patch acceptable to commit?
2001-05-04 Jeffrey D. Oldham <oldham at codesourcery.com>
* FieldEngine.NoGeometry.h (FieldEngine::physicalCellDomain):
Modify return type by removing reference. Change second function
call argument to match function prototype.
(FieldEngine::totalCellDomain): Change second function call
argument to match function prototype.
Tested using Linux gcc 3.0 single-thread by compiling Dave Nystrom's code
and building Pooma library
Approved by ???you???
Thanks,
Jeffrey D. Oldham
oldham at codesourcery.com
-------------- next part --------------
Index: FieldEngine.NoGeometry.h
===================================================================
RCS file: /home/pooma/Repository/r2/src/NewField/FieldEngine/FieldEngine.NoGeometry.h,v
retrieving revision 1.4
diff -c -p -r1.4 FieldEngine.NoGeometry.h
*** FieldEngine.NoGeometry.h 2001/04/10 23:13:25 1.4
--- FieldEngine.NoGeometry.h 2001/05/04 19:44:35
*************** public:
*** 254,267 ****
// This field-engine always has vert-centering and the total domain is
// given by the engine.
! inline const Domain_t &physicalCellDomain() const
{
! return shrink(physicalDomain(), 1);
}
inline Domain_t totalCellDomain() const
{
! return shrink(engine_m.domain(), 1);
}
Domain_t physicalDomain() const
--- 254,267 ----
// This field-engine always has vert-centering and the total domain is
// given by the engine.
! inline const Domain_t physicalCellDomain() const
{
! return shrinkRight(physicalDomain(), 1);
}
inline Domain_t totalCellDomain() const
{
! return shrinkRight(engine_m.domain(), 1);
}
Domain_t physicalDomain() const