[pooma-dev] Patch: Test Files

[Mark Mitchell]

>>>>> "Julian" == Julian C Cummings <cummings at linkline.com> writes:

    Julian> Jeffrey,

    Julian> I'm a bit concerned about your changes to prepend std:: to
    Julian> uses of iostream.  Jim raised the point that this may not
    Julian> yet be supported by all compilers in use.  Also, this sort
    Julian> of change needs to be done in a universal way across the
    Julian> entire Pooma code base.  Finally, as Jim noted, it might
    Julian> be better to go with specific using declarations at the
    Julian> top of .cpp files, rather than writing std:: everywhere.
    Julian> Did you ever address these points that Jim raised?  I tend
    Julian> to agree with him on these things.

Me, too.  We should definitely *not* put `std::' in everywhere.  That
assumes a compliant library, and relatively many compilers do not
provide this.

There should simply be:

  #if USING_STD_NAMESPACE
  using std::istream;
  ...
  #endif 

in the files that need it.

--
Mark Mitchell                   mark at codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com